[FFmpeg-devel] [PATCH] Make avfilter_config_links() propagate audio information of the source link if it is not explicitely set by the filter.

Michael Niedermayer michaelni
Mon Feb 14 23:39:15 CET 2011


On Mon, Feb 14, 2011 at 08:38:02PM +0100, Stefano Sabatini wrote:
> On date Monday 2011-02-14 17:57:37 +0000, M?ns Rullg?rd encoded:
> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> [...]
> > >> What if there is more than one input?  Are more complex cases assumed to
> > >> provide explicit parameters? 
> > >
> > > Yes, if a filter doesn't explicitely set the values they're set using
> > > the values in the first input link. This is a quite safe assumption
> > > and works fine for most 1-input/1-output filters.
> > >
> > >> Is this input certain to be an audio input?
> > >
> > > No, it is set anyway, a check may be added but right now it would be
> > > quite pointless anyway since the value is not used by video filters.
> > 
> > OK, it certainly can't be worse than not setting it at all.
> > 
> > However, the patch doesn't apply to current master.  Could you please
> > rebase and resend it?
> 
> Updated.
> -- 
> FFmpeg = Fancy Fundamental Marvellous Purposeless Elected Game

>  avfilter.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 3d4bbccbb20fc3f41a9bb1c74cda1036e418549d  0002-Make-avfilter_config_links-propagate-audio-informati.patch

commited, will push when it passes tests

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110214/dc201b3d/attachment.pgp>



More information about the ffmpeg-devel mailing list