[FFmpeg-devel] [PATCH] ac3enc: fix bug in stereo rematrixing decision.

[Justin Ruggles]

On 02/15/2011 08:01 PM, M?ns Rullg?rd wrote:

> Justin Ruggles <justin.ruggles at gmail.com> writes:
> 
>> On 02/15/2011 07:39 PM, M?ns Rullg?rd wrote:
>>
>>> Justin Ruggles <justin.ruggles at gmail.com> writes:
>>>
>>>> The rematrixing strategy reuse flags are not reset between frames, so they
>>>> need to be initialized for all blocks, not just block 0.
>>>> ---
>>>> We either have to check for !block->new_rematrixing_strategy or blk.  I can't remove both. Here is an alternative patch.
>>>
>>> Yes, you can.  Writing 1 to something that is already 1 is harmless.
>>
>> but dereferencing a NULL pointer (block0) is not harmless.
> 
> Right, it's null there.  Then I'd prefer checking blk, it's simpler.


Ok. That would be the most recently sent version of the patch then. Any
other issues with it?

Thanks,
Justin