[FFmpeg-devel] [PATCH] dxva2 mingw

[Víctor Paesa]

Hi,

On Sat, Feb 19, 2011 at 04:06, Kyle wrote:
> On 2/18/2011 9:48 PM, M?ns Rullg?rd wrote:
>>
>> Kyle<kshawkeye at gmail.com> ?writes:
>>
>>> This patch needs to be applied to FFmpeg before dxva2 will build with
>>> mingw
>>>
>>> diff --git a/libavcodec/dxva2_internal.h b/libavcodec/dxva2_internal.h
>>> index a9be7a0..23d4d87 100644
>>> --- a/libavcodec/dxva2_internal.h
>>> +++ b/libavcodec/dxva2_internal.h
>>> @@ -23,6 +23,8 @@
>>> ?#ifndef AVCODEC_DXVA_INTERNAL_H
>>> ?#define AVCODEC_DXVA_INTERNAL_H
>>>
>>> +#define _WIN32_WINNT 0x0600
>>> +#define COBJMACROS
>>> ?#include "dxva2.h"
>>> ?#include "avcodec.h"
>>> ?#include "mpegvideo.h"
>>
>> Could you please explain why this is needed? ?I'm not disputing that it
>> is, nor am I rejecting the patch. ?I am simply curious to know the reason.
>>
> FFmpeg fails to make with:
>
> CC libavcodec/dxva2.o
> In file included from libavcodec/dxva2_internal.h:26:0,
> from libavcodec/dxva2.c:23:
> libavcodec/dxva2.h:40:5: error: unknown type name ?IDirectXVideoDecoder?
> libavcodec/dxva2.h:45:5: error: unknown type name
> ?DXVA2_ConfigPictureDecode?
> libavcodec/dxva2.h:55:5: error: unknown type name ?LPDIRECT3DSURFACE9?
> In file included from libavcodec/dxva2.c:23:0:
> libavcodec/dxva2_internal.h:36:28: error: unknown type name
> ?DXVA2_DecodeBufferDesc?
> libavcodec/dxva2_internal.h:45:51: error: unknown type name
> ?DXVA2_DecodeBufferDesc?
> libavcodec/dxva2_internal.h:46:51: error: unknown type name
> ?DXVA2_DecodeBufferDesc?
> libavcodec/dxva2.c:46:28: error: unknown type name ?DXVA2_DecodeBufferDesc?
> libavcodec/dxva2.c:83:51: error: unknown type name ?DXVA2_DecodeBufferDesc?
> libavcodec/dxva2.c:84:51: error: unknown type name ?DXVA2_DecodeBufferDesc?
> make: *** [libavcodec/dxva2.o] Error 1
>
> Without it.

Yes, the defines are needed, either there or in configure or as extra-cflags.

http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2011-January/102911.html

Regards,
V?ctor