[FFmpeg-devel] [PATCH] movenc: convert put_tag() into ffio_wfourcc().

[Ronald S. Bultje]

Hi,

On Fri, Feb 25, 2011 at 7:10 PM, Baptiste Coudurier
<baptiste.coudurier at gmail.com> wrote:
> Hi,
>
> On 02/25/2011 02:36 PM, Ronald S. Bultje wrote:
>>
>> ---
>> ?libavformat/movenc.c | ? ?6 +++---
>> ?1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index 93d6ce9..57a6d11 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -1241,16 +1241,16 @@ static int mov_write_tapt_tag(ByteIOContext *pb,
>> MOVTrack *track)
>> ? ? ?int64_t pos = url_ftell(pb);
>>
>> ? ? ?avio_wb32(pb, 0); /* size */
>> - ? ?put_tag(pb, "tapt");
>> + ? ?ffio_wfourcc(pb, "tapt");
>>
>> ? ? ?avio_wb32(pb, 20);
>> - ? ?put_tag(pb, "clef");
>> + ? ?ffio_wfourcc(pb, "clef");
>> ? ? ?avio_wb32(pb, 0);
>> ? ? ?avio_wb32(pb, width<< ?16);
>> ? ? ?avio_wb32(pb, track->enc->height<< ?16);
>>
>> ? ? ?avio_wb32(pb, 20);
>> - ? ?put_tag(pb, "enof");
>> + ? ?ffio_wfourcc(pb, "enof");
>> ? ? ?avio_wb32(pb, 0);
>> ? ? ?avio_wb32(pb, track->enc->width<< ?16);
>> ? ? ?avio_wb32(pb, track->enc->height<< ?16);
>
> This name is extremely ugly.

I'd be happy to replace it with something better. It's in a private
header and ff-prefixed, so completely private API that we can change
at any time.

Ronald