[FFmpeg-devel] [PATCH] movenc: convert put_tag() into ffio_wfourcc().

[Alex Converse]

On Sat, Feb 26, 2011 at 2:03 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Feb 25, 2011 at 04:10:26PM -0800, Baptiste Coudurier wrote:
>> Hi,
>>
>> On 02/25/2011 02:36 PM, Ronald S. Bultje wrote:
>>> ---
>>> ? libavformat/movenc.c | ? ?6 +++---
>>> ? 1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>>> index 93d6ce9..57a6d11 100644
>>> --- a/libavformat/movenc.c
>>> +++ b/libavformat/movenc.c
>>> @@ -1241,16 +1241,16 @@ static int mov_write_tapt_tag(ByteIOContext *pb, MOVTrack *track)
>>> ? ? ? int64_t pos = url_ftell(pb);
>>>
>>> ? ? ? avio_wb32(pb, 0); /* size */
>>> - ? ?put_tag(pb, "tapt");
>>> + ? ?ffio_wfourcc(pb, "tapt");
>>>
>>> ? ? ? avio_wb32(pb, 20);
>>> - ? ?put_tag(pb, "clef");
>>> + ? ?ffio_wfourcc(pb, "clef");
>>> ? ? ? avio_wb32(pb, 0);
>>> ? ? ? avio_wb32(pb, width<< ?16);
>>> ? ? ? avio_wb32(pb, track->enc->height<< ?16);
>>>
>>> ? ? ? avio_wb32(pb, 20);
>>> - ? ?put_tag(pb, "enof");
>>> + ? ?ffio_wfourcc(pb, "enof");
>>> ? ? ? avio_wb32(pb, 0);
>>> ? ? ? avio_wb32(pb, track->enc->width<< ?16);
>>> ? ? ? avio_wb32(pb, track->enc->height<< ?16);
>>
>> This name is extremely ugly.
>
> yes, the API is also worse
>
> put_tag() worked with things that had length different from 4
> sane thing would have been to make it ffio_put_tag() with put_tag() API
> I tried to participate in the renamings but after ronald asked if we shall
> vote and i asked for a vote ...
> Anyone remembers being asked? a vote?

http://www.youtube.com/watch?v=-F-3E8pyjFo#t=27m35s

> no, well, thats why i gave up. a vote amongt 4 hand picked people of the new
> team on IRC is pointless. Thats not a vote
>
> I can just offer that ffmpeg at videolan could provide an alternative API while
> maintaining compatibility to this mess until the ronald/mans fork died.
>