[FFmpeg-devel] [PATCH] document and make av_set_systematic_pal public

Ronald S. Bultje rsbultje
Mon Mar 7 20:49:43 CET 2011


Hi,

On Thu, Feb 10, 2011 at 4:52 AM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Thursday 2011-02-10 09:36:14 +0100, Reinhard Tartler encoded:
>> On Mi, Feb 09, 2011 at 22:36:39 (CET), Reinhard Tartler wrote:
>>
>> > This function was formerly known by the name ff_set_systematic_pal2
>> > ---
>> > ?libavcodec/bmpenc.c ? ? | ? ?2 +-
>> > ?libavcodec/imgconvert.c | ? ?2 +-
>> > ?libavcodec/rawdec.c ? ? | ? ?2 +-
>> > ?libavcodec/utils.c ? ? ?| ? ?2 +-
>> > ?libavutil/imgutils.c ? ?| ? ?4 ++--
>> > ?libavutil/imgutils.h ? ?| ? ?9 ++++++++-
>> > ?6 files changed, 14 insertions(+), 7 deletions(-)
>>
>> This patch is actually a RFC. I'm actually not terribly convinced that
>> this function should be made public, and TBH, I feel to rather belongs
>> (back) in libavcodec.
>
> Which is the rationale for the move?
> That is why it should be made public?
> Why it should be moved to lavc (being currently used in lavcore)?

I agree with Stefano here, lavu seems like the correct place, it being
potentially shareable between lavfilter/swscale/lavcodec. Is there a
reason this patch was not applied?

Ronald



More information about the ffmpeg-devel mailing list