[FFmpeg-devel] [FFmpeg-commits] aacenc: remove the data arrays

Nathan Caldwell saintdev
Tue Mar 8 09:25:30 CET 2011


On Mon, Mar 7, 2011 at 11:51 PM, Young Han Lee <cpumaker at gmail.com> wrote:
> Hi
>
> On Tue, Mar 8, 2011 at 2:37 PM, Nathan Caldwell <saintdev at gmail.com> wrote:
>>
>> On Mon, Mar 7, 2011 at 10:28 AM, Young Han Lee <git at ffmpeg.org> wrote:
>> > Module: ffmpeg
>> > Branch: master
>> > Commit: 2790d7a9ffbd51f33e5367a31ace5c44c30401a1
>> >
>> > Author: ? ?Young Han Lee <cpumaker at gmail.com>
>> > Committer: Ronald S. Bultje <rsbultje at gmail.com>
>> > Date: ? ? ?Fri Feb 18 09:33:11 2011 +0900
>> >
>> > aacenc: remove the data arrays
>> >
>> > Signed-off-by: Ronald S. Bultje <rsbultje at gmail.com>
>>
>> Could we revert this? It's causing the encoder to segfault, and I
>> don't know enough about alignment to fix it.
>
> I'm sorry about it
> Before I posted this patch, I have tested it using 5 different files and I
> found no problem.
> I just tested the latest version again but still it worked with no
> difference from the previous version.
> Could you give me any additional information about the problem?
> It will be very helpful to fix the problem.

See the patch I just sent. You may be able to come up with a better
solution. I didn't feel like putting too much thought into it.


-- 
-Nathan Caldwell



More information about the ffmpeg-devel mailing list