[FFmpeg-devel] [PATCH] lavf: move ff_get_v from avio.h to avio_internal.h

Måns Rullgård mans
Thu Mar 10 22:04:57 CET 2011


Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Thu, Mar 10, 2011 at 03:36:49PM -0500, Ronald S. Bultje wrote:
>> Hi,
>> 
>> On Thu, Mar 10, 2011 at 3:24 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Thu, Mar 10, 2011 at 03:09:47PM -0500, Ronald S. Bultje wrote:
>> >> Hi,
>> >>
>> >> On Thu, Mar 10, 2011 at 2:09 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> > On Thu, Mar 10, 2011 at 07:07:46PM +0100, Anton Khirnov wrote:
>> >> >> +uint64_t ffio_read_varlen(AVIOContext *bc);
>> >> >
>> >> > IMHO the name is wrose
>> >>
>> >> Please suggest a better name.
>> >
>> > i already suggested one
>> > IIRC something like
>> > ffio_nut_get_v()
>> > v in nut is a unique and unambigous thing
>> > varlen can mean millions of different encodings
>> 
>> And you still wonder why we don't take you seriously.
>
> Why? Keep in mind it is only used in mpc8 and nut.

That you know of.  I've seen it in a few other completely unrelated
places too.  As encodings go, it's one of the more obvious ones.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list