[FFmpeg-devel] [PATCH 5/7] CrystalHD: Bring in h.264 parser to establish picture type.

[Philip Langdale]

 On Sun, 27 Mar 2011 20:06:36 +0200, Michael Niedermayer 
 <michaelni at gmx.at> wrote:
>>
>> Hm, that is suspicious, avidec.c has specifically:
>> st->need_parsing = AVSTREAM_PARSE_HEADERS; // This is needed to get 
>> the pict type which is necessary for generating correct pts.
>> If that does not actually parse headers I guess somethings are going 
>> wrong.
>
> I confirm, this is a bug in the h264 parser
>
> bugfix welcome, i suspect it should be relatively easy

 Easy if you understand the correct semantics of 
 PARSER_FLAG_COMPLETE_FRAMES... :-)

 I'm guessing it means to assume the packet is exactly one frame? So 
 you'd want to
 move everything from parse_nal_units() on out of the else block?

 --phil