[FFmpeg-devel] Fw: [PATCH] DirectShow patches

[Stefano Sabatini]

On date Wednesday 2011-09-14 19:29:53 -0300, Ramiro Polla encoded:
> On Wed, Sep 14, 2011 at 5:48 PM, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Tuesday 2011-09-13 15:14:04 -0300, Ramiro Polla encoded:
> [...]
> >> +    if (ctx->list_options) {
> >> +        if (ctx->device_name[VideoDevice])
> >> +            dshow_list_device_options(avctx, devenum, VideoDevice);
> >> +        if (ctx->device_name[AudioDevice])
> >> +            dshow_list_device_options(avctx, devenum, AudioDevice);
> >> +        ret = AVERROR_EXIT;
> >> +        goto error;
> >> +    }
> >
> > Note: would be possible to find more than one audio/video "subdevices"
> > in a single dshow device?
> 
> I'm guessing it should be possible to have more capture filters
> connected to the graph, but right now the code doesn't support that.
> 
> [...]
> > Of course I assume all your patches have been tested. I'll push them
> > in a few days if no one wants to comment on the patches, I can
> > eventually fix the few remaining nits myself before committing in case
> > you don't reply to this one.
> 
> Please do. As I've said a couple of times, the descriptions and
> strings are mostly copied from other places, so if they're not good
> here they're not good at other places either, and it would be best to
> fix them all at the same time.

Yes, but correct in one place is better than consistently wrong
everywhere ;-).

And pushed, thanks for the cool patchset!
-- 
FFmpeg = Freak Frenzy Magical Portable Emblematic Game