[FFmpeg-devel] [PATCH 3/3] mov: support timecode extraction.

Clément Bœsch ubitux at gmail.com
Thu Jan 5 17:40:56 CET 2012


On Thu, Jan 05, 2012 at 12:28:25PM +0100, Clément Bœsch wrote:
[...]
> > Why 2 params for check_timecode_rate when passing a struct tcblah would
> > be sufficient.
> 
> This was an internal function at first and thus wasn't opaque for clarity.
> Yes I could export it using the struct for usage between libs; I'll update
> the patchset.
> 

Actually, the function has no struct timecode as parameter because it is
pre-init; the init function being in need of a string ATM, it's the
simpler way of dealing with this. The API should be changed to have an
init function, and a load_from_string. This will require more changes, and
can be think later since this is not the purpose of the patchset.

So I'd like to keep the current patchset as it is now if you don't mind.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120105/47a39f01/attachment.asc>


More information about the ffmpeg-devel mailing list