[FFmpeg-devel] [PATCH] mxfdec: Always compute essence container lengths

[Reimar Döffinger]

On Tue, Jan 10, 2012 at 04:07:14PM +0100, Tomas Härdin wrote:
> From 747239149c40fbdadec26f1b17bab2c18516e0c2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <tomas.hardin at codemill.se>
> Date: Tue, 10 Jan 2012 15:54:59 +0100
> Subject: [PATCH] mxfdec: Always compute essence container lengths
> 
> While we don't need to do this for files that follow the OPAtom spec there are
> some files like 2011_DCPTEST_24FPS.V.mxf that claim to be OPAtom but are clip-
> wrapped.

Maybe you should detect this case somehow and print a warning then?

> +                    * For these files essence_length will be BS, fixed by mxf_compute_essence_containers().

BS is not an obvious abbreviation IMHO, better write it differently.

> +                    * We still need to essence_length set for OPAtom files that lack a footer though.

Something's wrong with the grammar, I think the "to" must go and a "to
be" belongs before set or some such.