[FFmpeg-devel] [PATCH] lavfi: add missing periods in descriptions.

[Stefano Sabatini]

On date Friday 2012-01-20 10:44:12 +0100, Clément Bœsch encoded:
> On Fri, Jan 20, 2012 at 07:49:16AM +0100, Reimar Döffinger wrote:
> > 
> > 
> > On 20 Jan 2012, at 00:16, Clément Bœsch <ubitux at gmail.com> wrote:
> > 
> > > ---
> > > libavfilter/af_pan.c          |    2 +-
> > > libavfilter/vf_fade.c         |    2 +-
> > > libavfilter/vf_yadif.c        |    2 +-
> > > libavfilter/vsrc_color.c      |    2 +-
> > > libavfilter/vsrc_mandelbrot.c |    2 +-
> > > 5 files changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c
> > > index c4e64c8..ca14eca 100644
> > > --- a/libavfilter/af_pan.c
> > > +++ b/libavfilter/af_pan.c
> > > @@ -285,7 +285,7 @@ static void filter_samples(AVFilterLink *inlink, AVFilterBufferRef *insamples)
> > > 
> > > AVFilter avfilter_af_pan = {
> > >     .name          = "pan",
> > > -    .description   = NULL_IF_CONFIG_SMALL("Remix channels with coefficients (panning)"),
> > > +    .description   = NULL_IF_CONFIG_SMALL("Remix channels with coefficients (panning)."),
> > 
> > I wonder why you would put a dot there, none of these are proper sentences...
> > 
> 

> Only a few in ffmpeg -filters are actually "proper sentences", but almost
> all of them had a dot; the issue is IMO not the dot, but the sentence. I
> was just changing the few descriptions left for next time one of these
> filter is used as a pattern for a new one.

It all depends on what we intend for "proper sentence", I suppose

"Remix channels with coefficients (panning)."

can be considered a proper sentence, just posted a patch with the
missing cases.

Capitalization and verbal form was discussed and settled when I
started to work on libavfilter more or less two years ago, Diego
proposed the current pattern which I find mostly reasonable.
-- 
FFmpeg = Furious & Free Marvellous Portentous Erratic Governor