[FFmpeg-devel] [PATCH] Add a --enable-valgrind configure option.

[Clément Bœsch]

On Fri, Jan 20, 2012 at 09:38:22PM +0100, Reimar Döffinger wrote:
> On Fri, Jan 20, 2012 at 09:12:58PM +0100, Clément Bœsch wrote:
> > > @@ -3239,6 +3242,7 @@ fi
> > >  
> > >  enabled debug && add_cflags -g"$debuglevel" && add_asflags -g"$debuglevel"
> > >  enabled coverage && add_cflags "-fprofile-arcs -ftest-coverage" && add_ldflags "-fprofile-arcs -ftest-coverage"
> > > +enabled valgrind && target_exec="valgrind --error-exitcode=1 --malloc-fill=0x2a --track-origins=yes --leak-check=full --gen-suppressions=all --suppressions=tests/fate-valgrind.supp"
> > 
> > What if we want extra valgrind flags?
> 
> Add it here or just do it the way we've done it before this patch.
> The point is to make it really easy to use one way, advanced users
> can surely figure something out.
> Of course it might possible to address this by making it an option
> where you have to specify the name of the binary where you could
> then also include options.
> 

OK

> > > --- /dev/null
> > > +++ b/tests/fate-valgrind.supp
> > > @@ -0,0 +1,27 @@
> > > +{
> > > +   zlib-inflate
> > > +   Memcheck:Cond
> > > +   fun:inflateReset2
> > > +   fun:inflateInit2_
> > > +}
> > 
> > Do you mind adding a reference to the related issue if you have it? So we
> > can easily see if it is still required in the future.
> 
> Don't have any and don't care to investigate really.
> 
> > For these, I'd be happy with this one in comment:
> > http://sourceware.org/bugzilla/show_bug.cgi?id=12424
> 
> Any idea what comments look like in suppression files.
> 

just a '#'

> > BTW, do you need all the Memcheck entries?
> 
> I only copy-pasted the generated suppressions so I expect
> yes.

OK. LGTM, thank you.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120120/41ee4724/attachment.asc>