[FFmpeg-devel] FRAPS skip frame handling

[Reimar Döffinger]

On Sat, Jan 21, 2012 at 03:33:16PM +0100, Michael Niedermayer wrote:
> On Sat, Jan 21, 2012 at 10:25:10AM +0100, Reimar Döffinger wrote:
> > Hello,
> > the FRAPS decoder seems to use reget_buffer for the single purpose of
> > skip frame handling.
> > This seems wasteful to me, isn't there some simpler way API-wise to
> > indicate "no change"/shouldn't just returning 0 work just as well?
> > One other reason to want to change it is because this seems like the
> > only thing making it possibly non-trivial (though not difficult I guess)
> > to make the decoder frame-multithreaded.
> 
> set data_size to 0 return buf_size
> h263dec.c does it too

That does not seem to work, breaks the time stamps:
--- ./tests/ref/fate/fraps-v2	2011-01-17 20:50:47.000000000 +0100
+++ tests/data/fate/fraps-v2	2012-01-21 20:13:38.000000000 +0100
@@ -1,10 +1,2 @@
 0, 0, 1179648, 0x99f80436
-0, 3000, 1179648, 0x99f80436
-0, 6000, 1179648, 0x99f80436
-0, 9000, 1179648, 0x99f80436
-0, 12000, 1179648, 0x99f80436
-0, 15000, 1179648, 0xe8ae7a30
-0, 18000, 1179648, 0xe8ae7a30
-0, 21000, 1179648, 0xe8ae7a30
-0, 24000, 1179648, 0xe8ae7a30
-0, 27000, 1179648, 0xe8ae7a30
+0, 3000, 1179648, 0xe8ae7a30
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fraps.diff
Type: text/x-diff
Size: 5373 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120121/6a165e30/attachment.bin>