[FFmpeg-devel] FRAPS skip frame handling

[Michael Niedermayer]

On Sun, Jan 22, 2012 at 05:07:18PM +0100, Reimar Döffinger wrote:
> On Sun, Jan 22, 2012 at 05:01:23PM +0100, Michael Niedermayer wrote:
> > > //XXX/FIXME this is a temporary hack until all encoders output pts
> > > and since it does not have enough information gets it wrong.
> > > The real WTF is that this hack is run without printing the slightest
> > > message. Would have saved me about an hour time if someone had
> > > simply made that hack say that the encoder is broken.
> > 
> > Is this a regression ?
> 
> I don't think so, see my other patch, fixing it will change insane
> amounts of FATE test results, so I don't think it has ever worked
> unless it was "smuggled in" at some point.

release/0.8 with your patch:

--- /home/michael/ffmpeg-git/ffmpeg/tests/ref/fate/fraps-v2 2012-01-12 23:23:32.653325524 +0100
+++ tests/data/fate/fraps-v2    2012-01-23 04:08:49.207999655 +0100
@@ -1,10 +1,5 @@
 0, 0, 1179648, 0x99f80436
-0, 3000, 1179648, 0x99f80436
-0, 6000, 1179648, 0x99f80436
-0, 9000, 1179648, 0x99f80436
-0, 12000, 1179648, 0x99f80436
-0, 15000, 1179648, 0xe8ae7a30
-0, 18000, 1179648, 0xe8ae7a30
-0, 21000, 1179648, 0xe8ae7a30
-0, 24000, 1179648, 0xe8ae7a30
-0, 27000, 1179648, 0xe8ae7a30
+0, 3000, 1179648, 0xe8ae7a30
+0, 6000, 1179648, 0xe8ae7a30
+0, 9000, 1179648, 0xe8ae7a30
+0, 12000, 1179648, 0xe8ae7a30
make: *** [fate-fraps-v2] Error 1


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120123/793bd501/attachment.asc>