[FFmpeg-devel] [PATCH 01/12] timecode: add write regressions tests.

[Clément Bœsch]

On Tue, Jan 24, 2012 at 01:38:47PM +0100, Stefano Sabatini wrote:
> On date Monday 2012-01-23 17:04:20 +0100, Clément Bœsch encoded:
> > From: Clément Bœsch <clement.boesch at smartjog.com>
> > 
> > ---
> >  tests/lavf-regression.sh |   34 ++++++++++++++++++++++++++++++----
> >  tests/ref/lavf/dv_fmt    |    4 ++++
> >  tests/ref/lavf/gxf       |    4 ++++
> >  tests/ref/lavf/mov       |    4 ++++
> >  tests/ref/lavf/mpg       |    4 ++++
> >  tests/ref/lavf/mxf       |    6 +++++-
> >  6 files changed, 51 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tests/lavf-regression.sh b/tests/lavf-regression.sh
> > index af34e86..56029a4 100755
> > --- a/tests/lavf-regression.sh
> > +++ b/tests/lavf-regression.sh
> > @@ -13,13 +13,35 @@ eval do_$test=y
> >  
> >  ENC_OPTS="$ENC_OPTS -metadata title=lavftest"
> >  
> > -do_lavf()
> > +do_lavf_nocrc()
> >  {
> >      file=${outfile}lavf.$1
> >      do_avconv $file $DEC_OPTS -f image2 -vcodec pgmyuv -i $raw_src $DEC_OPTS -ar 44100 -f s16le -i $pcm_src $ENC_OPTS -b:a 64k -t 1 -qscale:v 10 $2
> > +}
> > +
> 
> > +do_lavf()
> > +{
> > +    do_lavf_nocrc "$@"
> >      do_avconv_crc $file $DEC_OPTS -i $target_path/$file $3
> >  }
> 
> I'm not sure why you don't want do_crc with timecodes.
> 

Well actually the CRC looked the same as long as I don't play with the
rate. Do you think it's worth keeping them? It's slowing down the tests
quite a bit if I do so, and I'm not sure they are actually useful in this
case.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120125/21bc7b51/attachment.asc>