[FFmpeg-devel] [PATCH 2/2] ffprobe: refactor frames decoding.

[Nicolas George]

L'octidi 8 thermidor, an CCXX, Stefano Sabatini a écrit :
> process_decoded_frame -> process_frame
> 
> the latter is simpler and seems less misleading (since the frame is
> not yet decoded)

Locally changed.

> > +            while (pkt1.size &&
> > +                   process_decoded_frame(w, fmt_ctx, &frame, &pkt1) > 0);
> nit: maybe drop "> 0".

process_(decoded)_frame() returning 0 means stop too, just not an error.

> Now this is doing:
> pkt->data += ret;
> pkt->size -= ret;
> 
> and pkt->data is NULL.
> 
> Verify that the decoder is returning 0 when the data is flushed (as I
> suppose it does).

The last patch of the patchset I just sent addresses that.

> Looks good otherwise, thanks.

Thanks, I'll push when the previous patch is updated.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120729/56ff2616/attachment.asc>