[FFmpeg-devel] [PATCH] tools: add make_chlayout_test.plx.

[Nicolas George]

Le duodi 12 thermidor, an CCXX, Stefano Sabatini a écrit :
> Why "plx" rather than "pl"?

.pl is the extension for the old "perl library" files; using it for scripts
was a misnomer. I have read (but can not find the source again) that Larry
Wall recommends .plx.

>			      Also, maybe drop the suffix, the other
> scripts in tools don't have it.

Done.

> options? Or "is a list of any valid ffmpeg option".

Clarified.

> This requirement is really strong, and could be avoided by exposing a
> list of channel layouts through an option/interface, and could also
> simplify much the code below (and make it more robust).

Done.

The rest is no longer relevant since the parsing is completely different.

Thanks for the review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120730/9b59b004/attachment.asc>