[FFmpeg-devel] [PATCH 1/2] ffplay: check return code of avcodec_decode_video2()

[Marton Balint]

On Sat, 9 Jun 2012, Michael Niedermayer wrote:

> On Sat, Jun 09, 2012 at 06:44:52PM +0200, Marton Balint wrote:
>> On Fri, 8 Jun 2012, Michael Niedermayer wrote:
>>
>>> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>>> ---
>>> ffplay.c |    3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/ffplay.c b/ffplay.c
>>> index cb62614..01a010e 100644
>>> --- a/ffplay.c
>>> +++ b/ffplay.c
>>> @@ -1504,7 +1504,8 @@ static int get_video_frame(VideoState *is, AVFrame *frame, int64_t *pts, AVPacke
>>>        return 0;
>>>    }
>>>
>>> -    avcodec_decode_video2(is->video_st->codec, frame, &got_picture, pkt);
>>> +    if(avcodec_decode_video2(is->video_st->codec, frame, &got_picture, pkt) < 0)
>>> +        return -1;
>>
>> On second thought, that should be return 0 instead, -1 will stop the
>> whole decoding process.
>
> yes :(
> should i post a patch?

No need, I pushed the fix to my tree, please merge.

Thanks,
Marton

>
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Those who are best at talking, realize last or never when they are wrong.
>