[FFmpeg-devel] [PATCH] lavf: add a real SRT muxer.
Clément Bœsch
ubitux at gmail.com
Thu Jun 21 18:56:47 CEST 2012
On Wed, Jun 20, 2012 at 09:49:50PM +0200, Nicolas George wrote:
> Le decadi 30 prairial, an CCXX, Clément Bœsch a écrit :
> > Can't this be moved to the SRTContext?
>
> Possibly, but while it is simple enough I do not want to bloat the context
> with an additional flag.
>
The point was just to avoid the write_ts assignment each time, like if it
was suggesting it could change between srt_write_packet() calls (or can
it?).
> > This could be in the write ts scope.
>
> Indeed, but I like the idea of having the index up to date even if it is not
> printed.
>
> > The rest LGTM. Another approach would be to try to detect the mode
> > according to the received packet.
>
> What do you mean exactly?
>
If it detects the "<num>\n... --> ..." form in the packet, it could assume
one mode or another. That might sound hacky though :)
[...]
--
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120621/6bcce462/attachment.asc>
More information about the ffmpeg-devel
mailing list