[FFmpeg-devel] [PATCH 2/2] Decode DTS XXCH extension

[Benjamin Larsson]

On 06/25/2012 08:56 AM, Nick Brereton wrote:
> On 2012-06-24 19:39, Nick Brereton wrote:
>
>> Hi,
>>
>> Second patch, implements reordering of channels from DTS-XXCH ordering
>> to avcodec's order, sets number of channels and layout.
>>
>> Unfortunately handling the channels for DTS extensions seems to be
>> rather messy as each extension seems to bring it's own scheme to the
>> table; I assume that adding XLL will only make it worse.
>>
>> Nick
>
> Updated patch 1/2 so updated this patch to allow for changes. Also fix
> formatting as per comments on first patch.
>
> Nick
>

> @@ -1979,7 +2105,6 @@ static int dca_decode_frame(AVCodecContext *avctx, void *data,
>      /* only scan for extensions if ext_descr was unknown or indicated a
>       * supported XCh extension */
>      if (s->core_ext_mask < 0 || s->core_ext_mask & (DCA_EXT_XCH | DCA_EXT_XXCH)) {
> -
>          /* if ext_descr was unknown, clear s->core_ext_mask so that the
>           * extensions scan can fill it up */
>          s->core_ext_mask = FFMAX(s->core_ext_mask, 0);


This hunk is unneeded.

LGTM otherwise.

MvH
Benjamin Larsson