[FFmpeg-devel] [PATCH] Fix pkg-config detection when using a cross-prefix

[Kyle]

On 6/30/2012 7:14 AM, Michael Niedermayer wrote:
> On Fri, Jun 29, 2012 at 10:08:06PM -0400, Kyle Schwarz wrote:
>> On 6/29/2012 11:04 AM, Michael Niedermayer wrote:
>>> On Fri, Jun 29, 2012 at 10:58:28AM -0400, Derek Buitenhuis wrote:
>>>> On 29/06/2012 2:30 AM, Kyle Schwarz wrote:
>>>>> The attached patch resolves a pkg-config issue.
>>>>>
>>>>> When a cross-prefix is used, FFmpeg searches for a cross-prefixed
>>>>> pkg-config, and fails to use pkg-config if none if found.
>>>>>
>>>>> This patch allows a native system pkg-config to be used if a prefixed
>>>>> one is not found.
>>>>
>>>> This seems like it could go quite wrong in some situations...
>>>
>>> seconded
>>
>> Can you give me an example of when it could go bad?
>
> what i had in mind (dunno if its the same as derek)
> assume you have cross compilation environments installed for
> 5 platforms, each needs different flags for the libs and has the
> libs in different places. How could 1 pkg-config be correct for all ?

The modification I made still searches for a cross prefixed pkg-config 
before it falls back to a native one.

pkg-config doesn't have to be compiled for the same system as the cross 
compiler, all it does it reads the pkgconfig files and reports what 
flags to set. The lib location is set by the pkgconfig files as well.

Every other program that I know of that utilizes pkg-config has a 
fallback to the native pkg-config when the cross prefixed one is not 
found. They also always fall back to the native pkg-config because I 
don't have a cross prefixed one set.

Best regards,
   Kyle Schwarz