[FFmpeg-devel] [PATCH 1/7] lavfi/tile: allow named arguments.

[Clément Bœsch]

On Sat, Nov 10, 2012 at 01:51:29AM +0100, Alexander Strasser wrote:
> Hi Clément,
> 
> Clément Bœsch wrote:
> [...]
> > +
> > +static const AVOption tile_options[] = {
> > +    { "size", "set tile size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "6x5"}, 0, 0, FLAGS },
> > +    { "s",    "set tile size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "6x5"}, 0, 0, FLAGS },
> 
>   The name "size" and the description seem misleading to me.
> 

I kind of agree…

>   Suggestion:
>   tiles, set layout of tiles
> 

…but this doesn't really sound better to me. Unless someone else complains
I'd like to keep "size" against "tiles". Maybe another suggestion would
change my mind.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121110/74601262/attachment.asc>