[FFmpeg-devel] [PATCH] lavfi: store and propagate number of channels information in audio buffer properties

[Stefano Sabatini]

On date Sunday 2012-11-11 13:54:50 +0100, Stefano Sabatini encoded:
> On date Sunday 2012-11-11 04:58:30 +0100, Michael Niedermayer encoded:
> > On Sun, Nov 11, 2012 at 04:46:13AM +0100, Michael Niedermayer wrote:
> [...]
> > > > i think at the end of the struct is a safer
> > > > and minor should be bumped
> > > > 
> > > > otherwise LGTM
> > > 
> > > ping
> > > 
> > > ive today fixed a security issue that a design based on this patch
> > > would have never made possible. Also currently we cannot transcode
> > > files with more than 8 channels, and to transcode a file without a
> > > layout that can be represented in the layout mask a random standard
> > > layout must be assigned to it, that is just wrong and also might
> > > produce damaged files containing incorrect layouts.
> > > 
> > > so this patch should not be left rotting ...
> > 
> > nicolas, stefano, ubitux any comments ?
> 
> Patch updated.
> 
> I didn't push the patch because there was no evidence that it was
> useful (indeed channels info is redundant with channel layout). Patch
> passes FATE here, push it or I'll do it tomorrow or later.
> -- 
> FFmpeg = Foolish Faithless Magical Prodigious Ecletic Genius

> From 7fd47218c9c5537ed0529d47769518fa26540e4e Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Mon, 30 Jul 2012 16:00:05 +0200
> Subject: [PATCH] lavfi: store and propagate number of channels information in
>  audio buffer properties
> 
> The channels field is required since the channel layout is not always
> available.
> 
> TODO: bump minor, add APIchanges entry
> ---
>  libavfilter/af_ashowinfo.c |    4 ++--
>  libavfilter/avcodec.c      |    2 ++
>  libavfilter/avfilter.h     |    1 +
>  3 files changed, 5 insertions(+), 2 deletions(-)

Applied.
-- 
FFmpeg = Faithless and Fascinating Minimal Powerful Embarassing Guide