[FFmpeg-devel] [PATCH] Fix distortion problem in MPEG1/2 video

[Michael Niedermayer]

On Tue, Nov 20, 2012 at 12:58:58PM +0900, Heesuk Jung wrote:
> Hi,
> 
> Thanks for your feedback and update response as below.
> 
> Reimar Doffinger wrote:
> 
> > I believe those are clearly broken files. Are they common enough that we
> should support them despite the speed cost for good files?
> 
>  -> I have reviewed pull parsing apply in other FFmpeg case(container-codec
> combination). I found that full parsing is sometimes used in limited
> container-codec combination like asfdec.c. And so I applied full parsing in
> AVI-MPEG1 / AVI-MPEG2 case. Also I verified this patch with embedded
> development environment and checked 50 files.
> Test result is OK and so suggested this patch.
> 
> > Otherwise I'd rather suggest to add an option to force full parsing + try
> to make the decoder detect this case and suggest that option.
> 
>  -> I agree that your suggestion is more reasonable but unfortunately I did
> not found solution to detect this case.

Both the uploaded files contain:
Metadata:
    encoder         : PotEncoder

is this a coincidence or do all files that need "full parsing" have
that metadata ?

If all have it then setting "full parsing" could be made conditional
on that metadata and mpeg1 || mpeg2
which should avoid reimars concerns about a slowdown for files not
needing full parsing

[...]

Thanks
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121120/2749732b/attachment.asc>