[FFmpeg-devel] [PATCH 1/6] tcp: use timeout option consistently

[Andrey Utkin]

In this edition, av_gettime() is called only if socket buffer is empty (in case of read) or full (in case of write)

---8<---

Default _connection_ timeout value 5 seconds is left as i/o timeout also
---
 libavformat/tcp.c |   49 +++++++++++++++++++++++++++++++++++++++----------
 1 files changed, 39 insertions(+), 10 deletions(-)

diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index 8cd217b..df39e78 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -43,9 +43,10 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
     char buf[256];
     int ret;
     socklen_t optlen;
-    int timeout = 50, listen_timeout = -1;
+    int listen_timeout = -1;
     char hostname[1024],proto[1024],path[1024];
     char portstr[10];
+    h->rw_timeout = 5000000;
 
     av_url_split(proto, sizeof(proto), NULL, 0, hostname, sizeof(hostname),
         &port, path, sizeof(path), uri);
@@ -60,7 +61,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
         if (av_find_info_tag(buf, sizeof(buf), "listen", p))
             listen_socket = 1;
         if (av_find_info_tag(buf, sizeof(buf), "timeout", p)) {
-            timeout = strtol(buf, NULL, 10);
+            h->rw_timeout = strtol(buf, NULL, 10);
         }
         if (av_find_info_tag(buf, sizeof(buf), "listen_timeout", p)) {
             listen_timeout = strtol(buf, NULL, 10);
@@ -126,6 +127,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
 
     if (ret < 0) {
         struct pollfd p = {fd, POLLOUT, 0};
+        int64_t wait_started;
         ret = ff_neterrno();
         if (ret == AVERROR(EINTR)) {
             if (ff_check_interrupt(&h->interrupt_callback)) {
@@ -139,7 +141,8 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
             goto fail;
 
         /* wait until we are connected or until abort */
-        while(timeout--) {
+        wait_started = av_gettime();
+        do {
             if (ff_check_interrupt(&h->interrupt_callback)) {
                 ret = AVERROR_EXIT;
                 goto fail1;
@@ -147,7 +150,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
             ret = poll(&p, 1, 100);
             if (ret > 0)
                 break;
-        }
+        } while (!h->rw_timeout || (av_gettime() - wait_started < h->rw_timeout));
         if (ret <= 0) {
             ret = AVERROR(ETIMEDOUT);
             goto fail;
@@ -192,9 +195,22 @@ static int tcp_read(URLContext *h, uint8_t *buf, int size)
     int ret;
 
     if (!(h->flags & AVIO_FLAG_NONBLOCK)) {
-        ret = ff_network_wait_fd(s->fd, 0);
-        if (ret < 0)
-            return ret;
+        int64_t wait_start = 0;
+        while (1) {
+            ret = ff_network_wait_fd(s->fd, 0);
+            if (!ret)
+                break;
+            if (ret != AVERROR(EAGAIN))
+                return ret;
+            if (ff_check_interrupt(&h->interrupt_callback))
+                return AVERROR_EXIT;
+            if (h->rw_timeout) {
+                if (!wait_start)
+                    wait_start = av_gettime();
+                else if (av_gettime() - wait_start > h->rw_timeout)
+                    return AVERROR(ETIMEDOUT);
+            }
+        }
     }
     ret = recv(s->fd, buf, size, 0);
     return ret < 0 ? ff_neterrno() : ret;
@@ -206,9 +222,22 @@ static int tcp_write(URLContext *h, const uint8_t *buf, int size)
     int ret;
 
     if (!(h->flags & AVIO_FLAG_NONBLOCK)) {
-        ret = ff_network_wait_fd(s->fd, 1);
-        if (ret < 0)
-            return ret;
+        int64_t wait_start = 0;
+        while (1) {
+            ret = ff_network_wait_fd(s->fd, 1);
+            if (!ret)
+                break;
+            if (ret != AVERROR(EAGAIN))
+                return ret;
+            if (ff_check_interrupt(&h->interrupt_callback))
+                return AVERROR_EXIT;
+            if (h->rw_timeout) {
+                if (!wait_start)
+                    wait_start = av_gettime();
+                else if (av_gettime() - wait_start > h->rw_timeout)
+                    return AVERROR(ETIMEDOUT);
+            }
+        }
     }
     ret = send(s->fd, buf, size, 0);
     return ret < 0 ? ff_neterrno() : ret;
-- 
1.7.8.6