[FFmpeg-devel] [PATCH] af_pan: Fix sscanf formats to work with buggy sscanf implementations

Hendrik Leppkes h.leppkes at gmail.com
Fri Sep 14 20:45:57 CEST 2012


On Fri, Sep 14, 2012 at 8:03 PM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 14/09/2012 1:19 PM, Nicolas George wrote:
> > You are not just removing the space before the trailing %n, I am a little
> > worried. I trust you checked that all combinations of spaces that did
> work
> > until now still work? I am a little worried about initial spaces. If so,
> ok.
>
> I think skip_spaces should take care of any leading white space here.
>

If i understand the code correctly, the only place where white space really
matters is in the places where we manually go against the arg pointer, and
before those places is a skip_spaces now.
sscanf itself simply skips any leading spaces in the input, i confirmed
this on windows and linux.

Leading spaces in the sscanf format string are completely unnecessary, its
implied by how sscanf works.


More information about the ffmpeg-devel mailing list