[FFmpeg-devel] [PATCH 1/9] lavf/oggdec: inline ogg_get_headers().

[Clément Bœsch]

On Sat, Sep 15, 2012 at 01:24:31AM +0200, Reimar Döffinger wrote:
> On Sat, Sep 15, 2012 at 01:20:40AM +0200, Clément Bœsch wrote:
> > There is no point in a distant definition of a small function like this
> > used only once.
> 
> I guess it makes sense, but on the other hand larger function and less
> documentation (by removing the function name) isn't exactly what that
> code needs...
> 

Yes I don't plan to do it for the larger ones. That little piece of code
looks pretty obvious to me, especially with the "while (!headers)" and the
debug message below.

The comment above could be better worded maybe.

> > Additionnal spacing to distinguish better the block.
> 
> Just one 'n' in additional

Ah right, thanks. Fixed locally.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120915/f7ea091e/attachment.asc>