[FFmpeg-devel] [PATCH 2/2] lavfi/sink_buffer: implement libav compatibility API.

[Michael Niedermayer]

On Wed, Sep 26, 2012 at 07:06:26PM +0200, Nicolas George wrote:
> Implement av_buffersink_read() and av_buffersink_read_samples()
> for ffmpeg's version of buffersink.
> 
> With this change, avconv linked against ffmpeg's libraries passes
> the same number of tests whether it uses ffbuffersink or
> buffersink_old.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavfilter/buffersink.c  |    6 +--
>  libavfilter/internal.h    |    4 ++
>  libavfilter/sink_buffer.c |  114 ++++++++++++++++++++++++++++++++++++++++++---
>  3 files changed, 115 insertions(+), 9 deletions(-)
> 
>

> With this change applied, incompatible_fork_abi is no longer needed and we
> can consider dropping the other implementation of buffersink at any time.

for me it seems crashing at fate-flic-magiccarpet, which it does not
do with incompatible_fork_abi

but the patch should be ok as i didnt notice a change when
incompatible_fork_abi is enabled

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff795e41f in vsink_init (ctx=0x63fb20, args=0x0, opaque=0x110) at libavfilter/sink_buffer.c:207
207     if (params && params->pixel_fmts) {
(gdb) bt
#0  0x00007ffff795e41f in vsink_init (ctx=0x63fb20, args=0x0, opaque=0x110) at libavfilter/sink_buffer.c:207
#1  0x00007ffff792904c in avfilter_init_filter (filter=0x63fb20, args=0x0, opaque=0x110) at libavfilter/avfilter.c:611
#2  0x00007ffff79292ac in avfilter_graph_create_filter (filt_ctx=0x62d320, filt=0x7ffff7bbac20, name=0x7fffffffce80 "output stream 0:0", args=0x0, opaque=0x110, graph_ctx=0x63f1c0)
    at libavfilter/avfiltergraph.c:89
#3  0x000000000040c692 in configure_output_video_filter (ofilter=0x62d320, fg=<optimized out>, out=<optimized out>) at avconv_filter.c:192
#4  0x000000000040d1c0 in configure_output_filter (fg=0x6265a0, ofilter=0x62d320, out=0x63f700) at avconv_filter.c:350
#5  0x000000000040d447 in configure_filtergraph (fg=0x6265a0) at avconv_filter.c:516
#6  0x0000000000410c80 in transcode_init () at avconv.c:1702
#7  0x0000000000405c1c in transcode () at avconv.c:2252
#8  main (argc=15, argv=0x7fffffffe438) at avconv.c:2442
(gdb) print params
$1 = (AVBufferSinkParams *) 0x110

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120926/8fee71c9/attachment.asc>