[FFmpeg-devel] [PATCH] cmdutils: remove error message from opt_default() in case of missing option

[Stefano Sabatini]

On date Thursday 2013-04-04 23:36:15 +0200, Clément Bœsch encoded:
> On Thu, Apr 04, 2013 at 10:23:32PM +0200, Stefano Sabatini wrote:
> > A similar error is generated in the calling function, avoid duplication.
> > ---
> >  cmdutils.c |    2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/cmdutils.c b/cmdutils.c
> > index 51ec634..831c528 100644
> > --- a/cmdutils.c
> > +++ b/cmdutils.c
> > @@ -547,8 +547,6 @@ int opt_default(void *optctx, const char *opt, const char *arg)
> >  
> >      if (consumed)
> >          return 0;
> > -    av_log(NULL, AV_LOG_ERROR, "Could not find option '%s' in any of the FFmpeg subsystems "
> > -           "(codec, format, scaler, resampler contexts)\n", opt);
> >      return AVERROR_OPTION_NOT_FOUND;
> >  }
> 
> LGTM, thanks, the -nostats false positive message was annoying :)

Applied.

The code IMO is still bugged, since it looks-up options in the
program, in contexts, and finally again in the program in case the
option looks like a boolean option, which is ... weird.
-- 
FFmpeg = Friendly & Frightening Mastodontic Philosophical Erudite Governor