[FFmpeg-devel] [PATCH 3/4] libavfilter/deshake_opencl: modify deshake calling opencl API 20130409

[Michael Niedermayer]

On Tue, Apr 09, 2013 at 04:15:29PM +0800, Wei Gao wrote:
> 

>  deshake_opencl.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 41e8cb7ae429ff98f342e4101df12395edcdaede  0003-modify-deshake-calling-opencl-API-20130409.patch
> From e90432e9aa6d4e27d02e21aba2e31689f93e06bf Mon Sep 17 00:00:00 2001
> From: highgod0401 <highgod0401 at gmail.com>
> Date: Tue, 9 Apr 2013 16:06:17 +0800
> Subject: [PATCH 3/4] modify deshake calling opencl API 20130409
> 
> ---
>  libavfilter/deshake_opencl.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/libavfilter/deshake_opencl.c b/libavfilter/deshake_opencl.c
> index 63d144a..0f6dcc4 100644
> --- a/libavfilter/deshake_opencl.c
> +++ b/libavfilter/deshake_opencl.c
> @@ -98,10 +98,7 @@ int ff_opencl_deshake_init(AVFilterContext *ctx)
>  {
>      int ret = 0;
>      DeshakeContext *deshake = ctx->priv;
> -    AVDictionary *options = NULL;
> -    av_dict_set(&options, "build_options", "-I.", 0);
> -    ret = av_opencl_init(options, NULL);
> -    av_dict_free(&options);
> +    ret = av_opencl_init(NULL);

if you change the av_opencl_init() function in one patch and change
the calling code in a seperate patch than the code would not work
between these 2 patches.
Thus these 2 changes should be in the same patch

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130409/506af6a4/attachment.asc>