[FFmpeg-devel] af_pan cannot parse arguments from example in documentation

[Michael Niedermayer]

On Sat, Apr 13, 2013 at 08:30:03AM +0200, Reimar Döffinger wrote:
> Hello,
> 
> On Fri, Apr 12, 2013 at 10:44:12AM +0300, Серж Нискородов wrote:
> > pan=stereo: FL < FL + 0.5*FC + 0.6*BL + 0.6*SL : FR < FR + 0.5*FC +
> > 0.6*BR + 0.6*SR
> > 
> > doesn't actually work ('Expected out channel name, got " FL < FL"')
> 
> I thought someone already fixed it?
> 
> > Ok. I found a regression and made a patch.
> > Here it is.
> > =-=-=-=
> > --- af_pan.c.orig 2013-03-15 02:09:17.000000000 +0200
> > +++ af_pan.c 2013-04-12 10:06:22.018300000 +0300
> > @@ -60,7 +60,7 @@
> > int64_t layout, layout0;
> > 
> > /* try to parse a channel name, e.g. "FL" */
> > - if (sscanf(*arg, "%7[A-Z]%n", buf, &len)) {
> > + if (sscanf(*arg, " %7[A-Z] %n", buf, &len)) {
> 
> Reportedly this syntax (with space before %n) does not
> work on Windows, so we cannot use it.

" %n" is used in af_pan.c, i assume that works ?
also
jacosubdec.c uses:
    if (sscanf(buf, "%u:%u:%u.%u %u:%u:%u.%u %n",
    if (sscanf(buf, "@%u @%u %n", &ts_start, &ts_end, &len) == 2)

are these ok?
Ive no means to test easily 

> Btw. should we add a patcheck test for that? Seems like it
> shouldn't be that hard...

thats surely a good idea

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130413/df17764e/attachment.asc>