[FFmpeg-devel] [PATCH] lavf: add libquvi demuxer.

[Clément Bœsch]

On Wed, Apr 10, 2013 at 07:22:31PM +0200, Stefano Sabatini wrote:
[...]
> > + at section libquvi
> > +
> > +Play media from Internet services using the quvi project.
> > +
> > +The demuxer accepts a @option{format} option to request a specific quality. It
> > +is by default set to @var{best}.
> > +
> > +See @url{http://quvi.sourceforge.net/} for more information.
> 
> Missing option description and some examples, sorely needed since
> libquvi documentation is not so complete nor easy to find.
> 

I'm not sure what kind of example you need...

  @example
  ffplay -format default 'http://www.youtube.com/watch?v=xxxxxxxxxx'
  @end example

?

[...]
> > +quvi_fail:
> > +    av_log(s, AV_LOG_ERROR, "%s\n", quvi_strerror(&q, rc));
> 
> This could be expanded a bit:
> 
> "Error occurred when parsing URL '%s': %s\n"
> 

The error is actually more than explicit already:

[libquvi @ 0x7f43c4000940] /usr/share/libquvi-scripts/lua/website/youtube.lua:112: This video does not exist. (code=100)

> > +    ret = rc;
> 
> is this a valid error code (shouldn't it be AVERROR_EXTERNAL or such)?
> 

Indeed, much better, changed. Also fixed a mistake in the error reporting.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130415/e0be3ba7/attachment.asc>