[FFmpeg-devel] [PATCH 2/2] mxfdec: fix return variable type for avio_seek

[Marton Balint]

On Thu, 11 Apr 2013, Marton Balint wrote:
>
> On Thu, 11 Apr 2013, Tomas Härdin wrote:
>
>> On Thu, 2013-04-11 at 01:09 +0200, Marton Balint wrote:
>>> Signed-off-by: Marton Balint <cus at passwd.hu>
>>> ---
>>>  libavformat/mxfdec.c | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
>>> index 9eeba55..b04fc25 100644
>>> --- a/libavformat/mxfdec.c
>>> +++ b/libavformat/mxfdec.c
>>> @@ -2437,6 +2437,7 @@ static int mxf_read_seek(AVFormatContext *s, int 
>>> stream_index, int64_t sample_ti
>>>      MXFContext* mxf = s->priv_data;
>>>      int64_t seekpos;
>>>      int i, ret;
>>> +    int64_t ret64;
>>>      MXFIndexTable *t;
>>>      MXFTrack *source_track = st->priv_data;
>>> 
>>> @@ -2451,8 +2452,8 @@ static int mxf_read_seek(AVFormatContext *s, int 
>>> stream_index, int64_t sample_ti
>>>          sample_time = 0;
>>>      seconds = av_rescale(sample_time, st->time_base.num, 
>>> st->time_base.den);
>>> 
>>> -    if ((ret = avio_seek(s->pb, (s->bit_rate * seconds) >> 3, SEEK_SET)) 
>>> < 0)
>>> -        return ret;
>>> +    if ((ret64 = avio_seek(s->pb, (s->bit_rate * seconds) >> 3, 
>>> SEEK_SET)) < 0)
>>> +        return ret64;
>> 
>> Does avio_seek() ever return < INT_MIN?
>> 
>
> According to specs it returns AVERROR on error which is I think safe to say 
> is 32bit.
>

Ping...

Thanks,
Marton