[FFmpeg-devel] [PATCH] fate/gif: create meaningful gif encoding tests.

[Clément Bœsch]

On Thu, Apr 18, 2013 at 11:43:14PM +0000, Paul B Mahol wrote:
> On 4/18/13, Clement Boesch <ubitux at gmail.com> wrote:
> > ---
> >  tests/fate/gif.mak              |  11 +++
> >  tests/lavf-regression.sh        |  15 +---
> >  tests/ref/fate/gifenc-bgr4_byte | 174
> > ++++++++++++++++++++++++++++++++++++++++
> >  tests/ref/fate/gifenc-bgr8      | 174
> > ++++++++++++++++++++++++++++++++++++++++
> >  tests/ref/fate/gifenc-gray      | 174
> > ++++++++++++++++++++++++++++++++++++++++
> >  tests/ref/fate/gifenc-pal8      | 174
> > ++++++++++++++++++++++++++++++++++++++++
> >  tests/ref/fate/gifenc-rgb4_byte | 174
> > ++++++++++++++++++++++++++++++++++++++++
> >  tests/ref/fate/gifenc-rgb8      | 174
> > ++++++++++++++++++++++++++++++++++++++++
> >  tests/ref/lavf/gif              |  21 -----
> >  9 files changed, 1056 insertions(+), 35 deletions(-)
> >  create mode 100644 tests/ref/fate/gifenc-bgr4_byte
> >  create mode 100644 tests/ref/fate/gifenc-bgr8
> >  create mode 100644 tests/ref/fate/gifenc-gray
> >  create mode 100644 tests/ref/fate/gifenc-pal8
> >  create mode 100644 tests/ref/fate/gifenc-rgb4_byte
> >  create mode 100644 tests/ref/fate/gifenc-rgb8
> >
> 
> lgtm (testing all pix fmts might be overkill)

gray is somehow special and I may add specific optim later, pal8 is
definitely special for the exported palette, rgb8 is a standard case, and
a _byte version is nice as well. That left 2 extra case which don't hurt
very much. If you think they should be removed, I'll do it.

Thanks for the review, applied.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130419/908e92ee/attachment.asc>