[FFmpeg-devel] [PATCH] lavfi/fade: Add ability to do video fade based on time

[Clément Bœsch]

On Sat, Apr 20, 2013 at 12:59:04PM -0400, Andy n Deanna wrote:
> Clément,
> 
> I have implemented all of your suggestions, with the exception of
> adding a test to FATE.  There is a subtle different between how the
> fade is calculated that makes some of the output frames slightly
> different when using the equivalent parameters.  The frame-based
> fade has a fixed difference between frames, so all of the rounding
> error happens at the end, whereas the time-based fade calculates the
> fade every frame, so the rounding error is distributed throughout
> the fade.  Not sure which is technically correct, but calculating at
> every frame seemed to be simpler for the time-based fade.
> 
> So to add a test to FATE, we need to add a new file to compare the
> output to.  That is currently outside of my abilities.  I can do it,
> but I need some guidance as to how to do it.
> 
> Summary of changes from last patch:
>   - Conditional logging for frame-based vs time-based.
>   - Fixed indentation and trailing whitespace (oops)
>   - Switch to AV_OPT_TYPE_DURATION
>   - Moved new options to the end
> 
> Thanks!
> Andy

> From 77c9528f1b736ef0f37402f41700ade0b2cf55e5 Mon Sep 17 00:00:00 2001
> From: Andy Martin <amartin at ubuntu.(none)>
> Date: Tue, 16 Apr 2013 21:35:02 -0400
> Subject: [PATCH] lavfi/fade: Added ability to do video fade based on
>  timestamp
> 
> ---
>  doc/filters.texi      |   18 ++++++++++
>  libavfilter/vf_fade.c |   95 ++++++++++++++++++++++++++++++++++++++++---------
>  2 files changed, 97 insertions(+), 16 deletions(-)
> 

Patch applied. Thank you for your contribution.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130421/4043c446/attachment.asc>