[FFmpeg-devel] [PATCH] Try to make new VDPAU usable by adding context to callback.

[Reimar Döffinger]

On 07.08.2013, at 23:44, Michael Niedermayer <michaelni at gmx.at> wrote:
> A function to allocate a AVVDPAUContext is needed to allow future
> extension i think (arguable this is orthogonal to this patch)
> 
> A function to set/get the render2 field is needed so as to allow
> multiple forks to add fields to the structure without breaking ABI
> 
> see MAKE_ACCESSORS()

I expected that comment, and it feels like a rather insane amount of effort.
The reason why I proposed it is that no fork can really add anything without a major bump anyway, so while doing all this would have been the only reasonable way in the first place, I'm not convinced it makes a difference now...

> iam not sure if this or a function ptr in AVCodecContext is
> simpler/better

The problem there is the use of vdpau types (though to be honest just using unsigned and void * instead should work fine), though due to the hwaccel mess I think it would be better.
But there are lots of details, for example I think it would make sense to make it a union to allow sonething similar for the other hwaccels, but I don't know how that would work with the accessors.