[FFmpeg-devel] [PATCH] libavcodec: Do not return encoding errors when -sub_charenc_mode is do_nothing

[Nicolas George]

Le primidi 11 fructidor, an CCXXI, Eelco Lempsink a écrit :
> Signed-off-by: Eelco Lempsink <eml at tupil.com>
> ---
>  libavcodec/utils.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

This is not what « do nothing » is meant for. It is meant for situations
where the muxer already did the job, and the check to ensure that the job
was done properly is still relevant.

If you want to bypass the check, please add a dedicated option, and clearly
document that any application that uses it is misdesigned and will not work
once the full recoding API is implemented.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130828/cff34973/attachment.asc>