[FFmpeg-devel] [PATCH] libavcodec: Do not return encoding errors when -sub_charenc_mode is do_nothing

[Nicolas George]

Once again, exactly the same arguments that I have already discussed at
least twice.

Le tridi 13 fructidor, an CCXXI, wm4 a écrit :
> Your simplistic patch (the text file one you sent to this list some
> time ago) would be a disimprovement. It completely takes the control
> over how charsets can be selected from the application, and replaces it

Not true. The application can control the selected encoding, that is a core
feature of the code.

> Ideally, we'd have perfect charset detection, and we'd have it in
> ffmpeg. However, that is not possible.

Since you realize that, please stop waving it around at every occasion.

> 					 What's left is any of those:
> automatic charset detection via statistic methods (Mozilla's code,
> ENCA, libicu, libguess, maybe more), and via user intervention. User

I already wrote that I will not object to someone implementing this kind of
method as an optional feature.

> intervention would mean that the user can select from a number of
> possible candidates if the encoding couldn't be reliably detected.

That is already what my code propose.

> Think GUIs. With your new patch, this would have to happen after ffmpeg
> already turned the subtitles into mojibake, which surely is against the
> goal.

Not true.

> By the way, what makes you even think that vim is good at handling
> charsets?

I use it.

>	    We have no reason to believe that. In fact, I bet vim really

"We"?

> sucks at international text - how is it going to render complex scripts
> like arabic or indic on the terminal?

Obviously, Vim is limited to what the terminal can print. How is it
relevant?

> Let me repeat again that probing a few hardcoded (or even user
> provided) charsets by trying to run iconv on them makes the worst
> charset detector possible.

Repeating it will not make it true.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130830/395b3c1c/attachment.asc>