[FFmpeg-devel] [PATCH] TLS OPENSSL SSL_get_error

[Carl Eugen Hoyos]

Mirko Puliafito <mirko.puliafito <at> eudata.biz> writes:

> It  could be interesting to create a simple guide on 
> patcheck in order to explain new contributors what 
> output means.

http://ffmpeg.org/developer.html#Submitting-patches-1

> I really didn't understand that my output reported 
> errors. What do you think?

A patch that improves the "tabs" output of patcheck 
is probably welcome.

The patch that you attached does not apply to current 
git head (I suspect you have to revert your previous 
commits).

The remaining issue with your patch is that now it 
does:

if (var == val1)
  do1;
else if (var == val2)
  do2;
else
  switch (var) {
  case val3:
    do3;
    break;
  default:
    do4;
  }

It should be either:
if (var == val1)
  do1;
else if (var == val2)
  do2;
else if (var == val3)
  do3;
else
  do4;

or:

switch (var) {
case val1:
  do1;
  break;
case val2:
  do2;
  break;
case val3:
  do3;
  break;
default:
  do4;
}


Please do not top-post on this mailing list, 
Carl Eugen