[FFmpeg-devel] [PATCH] libavcodec/dvbsub: fix for Display Definition Segment

[Kieran Kunhya]

On 13 December 2013 13:29, Pierre Yves MORDRET
<pierre-yves.mordret at st.com> wrote:
> Given ETSI EN 300 743 V1.3.1 (2006-11), 7.2.1 Display definition segment
> display window parameters are given in this order XMin, XMax, YMin, YMax
> if  display_window_flag is set, but here this is not the case.
> As a consequence the DVB subtitles are not displayed upon some videos.
>
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret at st.com>
> ---
>  libavcodec/dvbsubdec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
> index 4ce40aa..2e845df 100644
> --- a/libavcodec/dvbsubdec.c
> +++ b/libavcodec/dvbsubdec.c
> @@ -1359,8 +1359,8 @@ static void dvbsub_parse_display_definition_segment(AVCodecContext *avctx,
>
>      if (info_byte & 1<<3) { // display_window_flag
>          display_def->x = bytestream_get_be16(&buf);
> -        display_def->y = bytestream_get_be16(&buf);
>          display_def->width  = bytestream_get_be16(&buf) - display_def->x + 1;
> +        display_def->y = bytestream_get_be16(&buf);
>          display_def->height = bytestream_get_be16(&buf) - display_def->y + 1;
>      }
>  }
> --
> 1.7.9.5
>

Looks ok