[FFmpeg-devel] [PATCH 9/9] ffplay: add -af option

[Marton Balint]

On Tue, 5 Feb 2013, Marton Balint wrote:

>
> On Sun, 3 Feb 2013, Stefano Sabatini wrote:
>
>> On date Sunday 2013-02-03 16:30:11 +0100, Stefano Sabatini encoded:
>> [...]
>>> Updated work in progress.
>>> 
>>> I'm not sure about how to handle configuration in open_audio(). Right
>>> now I'm configuring the filtergraph, *then* opening the audio device.
>>> 
>>> In order to minimize changes, in audio_decode_frame() (which should be
>>> renamed something like audio_process_frame) I'm passing is->frame to
>>> the filtergraph, and I convert it back to is->frame if I manage to get
>>> a frame. Then the data is handled the usual way.
>>> 
>>> In case the device target configuration differs from the output
>>> filter, the normalization code in audio_decode_frame() should convert
>>> it to the target configurations (possibly not very efficient).
>>> Alternatively: we configure the filters, open the device, then
>>> *reconfigure* the filters to take into account of the device
>>> configuration (and virtually avoids the need for the output
>>> normalization).
>>> 
>>> The current design doesn't address the case where the input changes,
>>> which should be addressed by either reconfiguring the filtergraph or
>>> adding another normalization layer between the decoder and the
>>> filtergraph.
>> 
>> Updated.
>> 
>> This one solves all the above mentioned problems, but it is currently
>> skipping sample compensation. The only approach I can see is to use a
>> dedicated swr context for that.
>> 
>> Not yet ready for commit, but feel free to comment.
>> -- 
>> FFmpeg = Free and Fundamentalist Multimedia Portable Enhancing Gem
>> 
>> From b03a8a5c31dbf600bb55d8381bb5eeac0c0e91e1 Mon Sep 17 00:00:00 2001
>> From: Stefano Sabatini <stefasab at gmail.com>
>> Date: Sun, 3 Feb 2013 21:29:01 +0100
>> Subject: [PATCH] ffplay: add -af option
>> 
>> ---
>> doc/ffplay.texi |    6 ++
>> ffplay.c        |  194 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++----
>> 2 files changed, 188 insertions(+), 12 deletions(-)

Stefano, were you able to work on this? If not, I may will have a little 
time to make the proposed changes if that's ok with you.

Regards,
Marton