[FFmpeg-devel] [PATCH] fate: add sub2video test.

[Clément Bœsch]

On Tue, Jan 01, 2013 at 06:51:54PM +0100, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  tests/fate/ffmpeg.mak    |    8 ++++++++
>  tests/ref/fate/sub2video |   51 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+)
>  create mode 100644 tests/ref/fate/sub2video
> 
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index 9845cd3..a352d75 100644
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -19,3 +19,11 @@ fate-force_key_frames: CMD = enc_dec \
>    "rawvideo -s 352x288 -pix_fmt yuv420p" tests/data/vsynth2.yuv \
>    avi "-c mpeg4 -g 240 -qscale 10 -force_key_frames 0.5,0:00:01.5" \
>    framecrc "" "" "-skip_frame nokey"
> +
> +FATE_SAMPLES_FFMPEG += fate-sub2video
> +fate-sub2video: tests/data/vsynth2.yuv
> +fate-sub2video: CMD = framecrc \
> +  -f rawvideo -r 5 -s 352x288 -pix_fmt yuv420p -i tests/data/vsynth2.yuv \
> +  -ss 132 -i $(SAMPLES)/sub/vobsub.idx \
> +  -filter_complex "[0:0]scale=720:480[v];[v][1:0]overlay" \
> +  -c rawvideo

Should be OK but since this is a new test, please add the dependencies.
Something like FATE_SAMPLES_FFMPEG-$(call ALLYES, VOBSUB_DEMUXER
DVDSUB_DECODER AVFILTER OVERLAY_FILTER ...) += fate-sub2video

Also, I wanted to add this test:
http://ffmpeg.org/pipermail/ffmpeg-devel/2012-December/135410.html

...which in addition to yours covers the dvdsub encoding (but lacks a lot
of other things). Instead of adding another test (which will re-cover
VobSub demux and dvdsub decode), could you also add the dvdsub stream
encoding to the test as a additional stream?

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130101/404aaaff/attachment.asc>