[FFmpeg-devel] libavformat/gifdec.c usage of AV_LOG_FATAL

[Don Moir]

----- Original Message ----- 
From: "Paul B Mahol" <onemda at gmail.com>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Thursday, January 03, 2013 12:17 PM
Subject: Re: [FFmpeg-devel] libavformat/gifdec.c usage of AV_LOG_FATAL


> On 1/3/13, Don Moir <donmoir at comcast.net> wrote:
>> ----- Original Message -----
>> From: "Paul B Mahol" <onemda at gmail.com>
>> To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
>> Sent: Wednesday, January 02, 2013 2:08 PM
>> Subject: Re: [FFmpeg-devel] libavformat/gifdec.c usage of AV_LOG_FATAL
>>
>>
>>> On 1/2/13, Don Moir <donmoir at comcast.net> wrote:
>>>> In gif_read_ext of libavformat/gifdec.c it uses AV_LOG_FATAL if
>>>> avio_r8(pb)
>>>> < 4.
>>>>
>>>> This is called during a packet read and it seems AV_LOG_FATAL should not
>>>> be
>>>> used. Is this improper usage ?
>>>
>>> Yes.
>>
>> I suppose it should be using AV_LOG_ERROR ?
>>
>> Are you going to address this Paul ?
>
> Maybe, I have far more critical stuff to work right now.

Understood. I ran into it when I added the ability to optionally calculate the duration for gif files but kind of backed off of it 
in favor of calculating the duration internally after I know its a gif. Just not to crazy about how the options work in this regard 
since you need to set the options for every file even it they don't apply when they need to be in place prior to open.