[FFmpeg-devel] [PATCH] ffmpeg: accept "chapters" as forced key frames.

[Stefano Sabatini]

On date Wednesday 2013-01-16 13:40:59 +0100, Nicolas George encoded:
> Allow to force a key frame at the beginning of each chapter.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  doc/ffmpeg.texi |   10 +++++++++-
>  ffmpeg.c        |   52 +++++++++++++++++++++++++++++++++++++++++++++-------
>  2 files changed, 54 insertions(+), 8 deletions(-)
> 
> 
> Stefano:
> > Anyway I'm not opposed to the patch,
> 
> Ok, thanks. Updated version with the documentation fixes (the empty lines
> were intentional, I find they enhance readability).
> 
> >					at the same time I'd like to find
> > a convenient way to express near-position conditions in a
> > flexible/extensible way, so we don't have rely on other options such
> > as "delta" in the segment muxer.
> 
> Yes, a generic solution would be nice in the long run.
> 
> Regards,
> 
> -- 
>   Nicolas George
> 
> 
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 8a29d5e..2f4ad92 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@ -555,9 +555,17 @@ Deprecated see -bsf
>  @item -force_key_frames[:@var{stream_specifier}] @var{time}[, at var{time}...] (@emph{output,per-stream})
>  Force key frames at the specified timestamps, more precisely at the first
>  frames after each specified time.
> +If one of the times is "@code{chapters}[@var{delta}]", it is expanded into
> +the time of the beginning of all chapters in the file, shifted by
> + at var{delta}.

It is not specified what @var{delta} is (and its unit).

[...]

Make sure it works with negative times, LGTM otherwise but maybe wait
for an explicit approval from Michael.
-- 
FFmpeg = Fundamentalist & Fundamental Multimedia Pitiful Enhanced Governor