[FFmpeg-devel] [PATCH 4/4] movenc: check that fps for tmcd is within encodable range.

[Michael Niedermayer]

On Thu, Jan 17, 2013 at 06:09:44PM +0000, Paul B Mahol wrote:
> On 1/17/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavformat/movenc.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > index d9b002e..b44f316 100644
> > --- a/libavformat/movenc.c
> > +++ b/libavformat/movenc.c
> > @@ -1149,6 +1149,9 @@ static int mov_write_tmcd_tag(AVIOContext *pb,
> > MOVTrack *track)
> >      int frame_duration = av_rescale(track->timescale,
> > track->enc->time_base.num, track->enc->time_base.den);
> >      int nb_frames = 1.0/av_q2d(track->enc->time_base) + 0.5;
> >
> > +    if (nb_frames > 255)
> > +        return AVERROR(EINVAL);
> > +
> 
> Missing message why it is wrong and commit log that explains why higher
> values do not make sense(guessing, since I know nothing about tmcd tag)

fixed, applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130124/ed0a4ccc/attachment.asc>