[FFmpeg-devel] [PATCH 1/2] Support parsing of BlockAdditional data in Matroska

[Vignesh Venkatasubramanian]

On Wed, Jan 30, 2013 at 1:45 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Vignesh Venkatasubramanian <vigneshv <at> google.com> writes:
>
>> Adds Ebml grammar definitions according to matroska specification for
>> parsing data in BlockAdditional element. Matroska Spec of
>> BlockAdditional: http://goo.gl/aFSl5
>
>> diff --git a/tests/fate/vpx.mak b/tests/fate/vpx.mak
>
> I tested the file you uploaded both with and without
> the patch, and the result of the fate-test is
> unchanged...
>
> Sorry if this is a stupid question, but isn't there
> a decoder patch that is missing from this patch-set?

The test result is unchanged because it considers only the decoded output. This
change affects only the demuxer and not the decoder. So the decoder output
remains unchanged. I didn't realize that when i submitted this patch, my bad.
I have now changed the test to compute the CRC taking the side_data into
account. I'll upload that patch shortly.

>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



--
Vignesh V | Software Engineer | vigneshv at google.com | 650-861-1330