[FFmpeg-devel] [PATCH] examples/muxing: add support to audio resampling

[Stefano Sabatini]

On date Tuesday 2013-07-02 23:46:58 +0200, Michael Niedermayer encoded:
> On Tue, Jul 02, 2013 at 10:57:00PM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2013-07-02 22:31:56 +0200, Michael Niedermayer encoded:
> > > On Tue, Jul 02, 2013 at 06:21:09PM +0200, Stefano Sabatini wrote:
> > > > Allows to encode to output in case the destination sample format is
> > > > different from AV_SAMPLE_FMT_S16.
> > > > ---
> > > >  doc/examples/muxing.c | 116 +++++++++++++++++++++++++++++++++++++++-----------
> > > >  1 file changed, 92 insertions(+), 24 deletions(-)
> > > 
> > 
> > > shouldnt resampling be in a seperate example from muxing ?
> > 
> > *But* right now this works only with a limited number of formats, and
> > I need a simple *working* application to exercise/test the API. Also
> > since we use the scaler to rescale video, it seems sensible to
> > resample audio as well (which is a bit more complicated).
> > 
> > Hopefully we will be able to simplify the API, but for the moment I
> > prefer a more complex example than a simpler but non realistic
> > example. And BTW we are also still missing flushing.
> 

> i dont mind but threre should be a more minimal example that doest
> drag in "everything".

We have more minimal examples. But again a simple and mostly
non-working example is not that helpful.

> Also we have ffmpeg/ffplay as full & usefull "examples"

Yes but they are not simple at all, especially ffmpeg.c since it's
split in many silly files.

...

Should I wait for technical review, or push it?
-- 
FFmpeg = Forgiving Free Mega Philosofic Exciting Genius