[FFmpeg-devel] [PATCH] lavf/adtsenc: Add support for APE tags

[James Almer]

On 11/07/13 5:00 PM, Thierry Foucu wrote:
> On Thu, Jul 11, 2013 at 11:08 AM, James Almer <jamrial at gmail.com> wrote:
> 
>> Should fix ticket #2269
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavformat/adtsenc.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c
>> index 60d7b07..7118105 100644
>> --- a/libavformat/adtsenc.c
>> +++ b/libavformat/adtsenc.c
>> @@ -25,6 +25,7 @@
>>  #include "libavcodec/avcodec.h"
>>  #include "libavcodec/mpeg4audio.h"
>>  #include "avformat.h"
>> +#include "apetag.h"
>>
>>  #define ADTS_HEADER_SIZE 7
>>
>> @@ -162,6 +163,13 @@ static int adts_write_packet(AVFormatContext *s,
>> AVPacket *pkt)
>>      return 0;
>>  }
>>
>> +static int adts_write_trailer(AVFormatContext *s)
>> +{
>> +    ff_ape_write_tag(s);
>>
> 
> I think this should be an option of the adts muxer as not all the adts
> decoder will know what to do with this and some will crash.
> and if some people use libav as a library and want to create adts chunk
> (HLS) they may be calling trailer at the end of each chunk and this will be
> adding the ape metadata.
> 
> What do you all think?
> 

I just checked and foobar2000 for example can't read any kind of tags stored on 
these files, be it APE or id3v1.
It didn't crash, though.

So yeah, i guess that it would be wise to make it optional.
I'll send an updated patch in a minute, and then whichever version is preferred 
can be committed.

Regards.